Try to solve this

Question

Hello Friends
There is an error showing for the below code
and also the maktx, lgort,labst data is not coming
i thought that the code was correct but the data is not showing. And also i want the grand total of the stock at the end of the plant & also subtotal of the stock for each storage location.
reply soon urgent.
*& Report  ZSTOCKDETAILS                                               *
REPORT  zstockdetails          NO STANDARD PAGE HEADING
                               LINE-SIZE 250
                               LINE-COUNT 22(3).
              tables declaration                 *
TABLES : mara,        "general material data
         marc,        "plant data for material
         mard,        "storage location data for material
         makt.        "material description
             internal table declaration             *
TYPES : BEGIN OF ty_mara,
        matnr TYPE matnr,
        END OF ty_mara.
TYPES : BEGIN OF ty_marc,
        matnr TYPE matnr,
        werks TYPE werks,
        END OF ty_marc.
TYPES : BEGIN OF ty_mard,
        matnr TYPE matnr,
        lgort TYPE lgort,
        labst TYPE labst,
        END OF ty_mard.
TYPES : BEGIN OF ty_makt,
        matnr TYPE matnr,
        maktx TYPE maktx,
        END OF ty_makt.
DATA:t_mara TYPE TABLE OF ty_mara WITH HEADER LINE,
     t_marc TYPE TABLE OF ty_marc WITH HEADER LINE,
     t_mard TYPE TABLE OF ty_mard WITH HEADER LINE,
     t_makt TYPE TABLE OF ty_makt WITH HEADER LINE.
                final internal table                    *
TYPES : BEGIN OF ty_out,
        matnr TYPE matnr,
        werks TYPE werks,
        lgort TYPE lgort,
        labst TYPE labst,
        maktx TYPE maktx,
        END OF ty_out.
DATA:t_out TYPE TABLE OF ty_out WITH HEADER LINE.
              selection screen                                 *
SELECTION-SCREEN BEGIN OF BLOCK b1 WITH FRAME TITLE text-001.
SELECT-OPTIONS : s_matnr FOR mara-matnr OBLIGATORY,
                 s_werks FOR marc-werks.
SELECTION-SCREEN END OF BLOCK b1.
             start-of-selection                                 *
START-OF-SELECTION.
  SELECT matnr
              FROM mara
                INTO TABLE t_mara
                 WHERE matnr IN s_matnr.
      if sy-subrc = 0.
   if not t_mara[] is initial.
  SELECT matnr werks
              FROM marc
                INTO TABLE t_marc
                 FOR ALL ENTRIES IN t_mara
                  WHERE matnr = t_mara-matnr
                  AND werks in s_werks.
       endif.
      endif.
    if sy-subrc = 0.
   if not t_marc[] is initial.
  SELECT matnr maktx
              FROM makt
                INTO TABLE t_makt
                 FOR ALL ENTRIES IN t_mara
                 WHERE matnr = t_mara-matnr.
   endif.
endif.
  SELECT matnr lgort labst
              FROM mard
                INTO TABLE t_mard
                 FOR ALL ENTRIES IN t_mara
                  WHERE matnr = t_mara-matnr.
  SORT : t_mara BY matnr,
         t_marc BY matnr,
         t_mard BY matnr,
         t_makt BY matnr.
  LOOP AT t_mara.
    READ TABLE t_marc WITH KEY matnr = t_mara-matnr BINARY SEARCH.
    READ TABLE t_mard WITH KEY matnr = t_mard-matnr BINARY SEARCH.
    READ TABLE t_makt WITH KEY matnr = t_makt-matnr BINARY SEARCH.
    MOVE : t_mara-matnr TO t_out-matnr,
           t_marc-werks TO t_out-werks,
           t_mard-lgort TO t_out-lgort,
           t_mard-labst TO t_out-labst,
           t_makt-maktx TO t_out-maktx.
    APPEND t_out.
    CLEAR t_out.
  ENDLOOP.
                   end-of-selection                             *
END-OF-SELECTION.
  LOOP AT t_out.
    WRITE :/ t_out-werks,
             t_out-lgort,
             t_out-matnr,
             t_out-maktx,
             t_out-labst.
  ENDLOOP.

Answer 1

Hi....
   While reading a table you need to specify all the keys required.
You have not included the Key fields required to get the unique records.
   for MARC table both MATNR and WERKS need to provided to get the unique records
   Similarly for the table MARD the key fields MATNR, WERKS and LGORT need to be provided to get the unique record.
Now in your case you are fetching the records based on material ...you will get multiple values of WERKS and LGORT for one MATNR... in that read statement will not be sufficient.
Check the below logic..
    LOOP AT t_mara.
       MOVE : t_mara-matnr TO t_out-matnr.
       LOOP AT T_MARC WHERE MATNR = T_MARA-MATNR.
         MOVE t_marc-werks TO t_out-werks.
         LOOP AT T_MARD WHERE MATNR = T_MARA-MATNR
                          AND WERKS = T_MARC-WERKS
         MOVE : t_mard-lgort TO t_out-lgort,
                t_mard-labst TO t_out-labst,
         ENDLOOP.
       ENDLOOP.
        READ TABLE t_makt WITH KEY matnr = t_makt-matnr 
               BINARY SEARCH.
        IF SY-SUBRC = 0.
          t_makt-maktx TO t_out-maktx.
        ENDIF.
   APPEND t_out.
   CLEAR t_out.
ENDLOOP.
Now the above logic should work fine. INcase you want to avoid nested loop, use inner joins to fetch records.
Regards,
Vara