Why is it drawing twice? WHY!!!?

Question

Hi,
Can someone please explain why the hell this thing is drawing twice?!?!?!?!
I've tried repaint and validate, but to no avail.
I'm just trying to make a simple kids game thingy - draws pictures, you press buttons and right disc moves left or right.
(you'll all be playing it in six months!)
What have I done wrong?
Thanks in advance.
2 java files follow:
import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
public class ImagePanel1 extends JPanel
// Declare an image array
    Image [] disc1Pics = new Image[36];
    Image [] disc2Pics = new Image[36];
//Declare temporary index list
    static int [] indexArray1 = new int [36];
    static int [] indexArray2 = new int [36];
// Declare x co-ords Array
    int [] xPos1 = {206, 214, 221, 234, 257, 281, 255, 285, 315, 255, 285, 315,
    234, 258, 281, 205, 213, 220, 170, 162, 155, 141, 118, 91, 122, 92, 62,
    122, 92, 62, 141, 118, 94, 169, 161, 154};
    int [] xPos2 = {606, 614, 621, 634, 657, 681, 655, 685, 715, 655, 685, 715,
    634, 658, 681, 605, 613, 620, 570, 562, 555, 541, 518, 494, 522, 492, 462,
    522, 492, 462, 541, 518, 494, 569, 561, 554};
// Declare y co-ords Array
    int [] yPos = {117, 87,  59,  141, 118, 94,  170, 162, 154, 204, 212, 220,
    234, 258, 281, 257, 287, 315, 257, 287, 315, 234, 257, 281, 204, 212, 220,
    171, 163, 155, 141, 118, 94, 117, 87, 59};
    public ImagePanel1()
        this.setBackground(Color.white);
// Create FOR loop to increment the 'pic number' - ie pic0, pic1, pic2
        for(int i1=0; i1<36; i1++)
        disc1Pics[i1] = Toolkit.getDefaultToolkit().getImage("pic"+i1+".gif");
        for (int j1=0; j1<36; j1++)
        indexArray1[j1] = j1;
        for (int lastPlace1 = indexArray1.length-1; lastPlace1 > 0; lastPlace1--)
// Choose a random location from among 0,1,...,lastPlace.
            int randLoc1 = (int)(Math.random()*(lastPlace1+1));
// Swap items in locations randLoc and lastPlace.
            int temp1 = indexArray1[randLoc1];
            indexArray1[randLoc1] = indexArray1[lastPlace1];
            indexArray1[lastPlace1] = temp1;
        for(int i2=0; i2<36; i2++)
        disc2Pics[i2] = Toolkit.getDefaultToolkit().getImage("pic"+i2+".gif");
        for (int j2=0; j2<36; j2++)
        indexArray2[j2] = j2;
        for (int lastPlace2 = indexArray2.length-1; lastPlace2 > 0; lastPlace2--)
// Choose a random location from among 0,1,...,lastPlace.
            int randLoc2 = (int)(Math.random()*(lastPlace2+1));
// Swap items in locations randLoc and lastPlace.
            int temp2 = indexArray2[randLoc2];
            indexArray2[randLoc2] = indexArray2[lastPlace2];
            indexArray2[lastPlace2] = temp2;
    public void paint (Graphics g)
        int x, y;
        double angle1=0;
        double angle1a=0.26166666666666666666666666666667;
        double angle2=0;
        Graphics2D g2d = (Graphics2D)g;
//          LEFT DISK                    LEFT DISK                    LEFT DISK
        do
            x=(int)(java.lang.Math.cos(angle1)*150)+200;
            y=(int)(java.lang.Math.sin(angle1)*150)+200;
//150 = radial length, 200 = co-ord of centre
            g.setColor(Color.black);
            g.drawLine(200,200,x,y);
            angle1 = angle1 + 0.52333333333333333333333333333333;
//0.52333 is 6.28/12 - ie 1/12th of 360 degrees in radians
        while (angle1<6.28);
//Create FOR loop with increment 'k' - equates to pic0, x_pos[0], y_pos[0], pic1, x_pos[1] etc
        //for(int k1=0; k1<36; k1++)
        //g.drawImage(disc1Pics[indexArray1[k1]],xPos1[k1],yPos[k1],this);
//          RIGHT DISK                    RIGHT DISK                    RIGHT DISK
        do
            x=(int)(java.lang.Math.cos(angle2)*150)+600;
            y=(int)(java.lang.Math.sin(angle2)*150)+200;
            g.setColor(Color.black);
            g.drawLine(600,200,x,y);
            angle2 = angle2 + 0.52333333333333333333333333333333;
        while (angle2<6.28);
        for(int k2=0; k2<36; k2++)
        g.drawImage(disc2Pics[indexArray2[k2]],xPos2[k2],yPos[k2],this);
//add in the circles
        g.drawOval(50,50,300,300);
        g.drawOval(450,50,300,300);
        g.setColor(Color.white);
        g.fillOval(163,163,74,74);
        g.fillOval(563,163,74,74);
        g.setColor(Color.black);
        g.drawOval(163,163,74,74);
        g.drawOval(563,163,74,74);
    public void doAntiClockwise()
        int current = 3;
        int [] temp = new int[indexArray2.length];
        for(int x=0; x<indexArray2.length; x++)
            if(current < indexArray2.length)
                temp[current] = indexArray2[x];
                current++;
            else
                current = 0;
        indexArray2 = temp;
        repaint();
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.util.*;
public class SafeCracker
    extends JFrame
    private JPanel buttonPanel, buttonPanel2, blank1, blank2, blank3,
        blank4, blank5, blank6;
    private JButton anti, clock, ok, disc1, disc2, disc3;
    ImagePanel1 myPanel = new ImagePanel1();
    public SafeCracker()
        super("SAFE CRACKER");
        JPanel panelForStuff = new JPanel();
        panelForStuff.setLayout(new BorderLayout());
        anti = new JButton("Anti-Clockwise");
        anti.addActionListener(new ActionListener()
            public void actionPerformed(ActionEvent ae)
               myPanel.doAntiClockwise();
        clock = new JButton("Clockwise");
        ok = new JButton("OK");
        disc1 = new JButton("Disc 1");
        disc2 = new JButton("Disc 2");
        disc3 = new JButton("Disc 3");
        blank1 = new JPanel();
        blank2 = new JPanel();
        blank3 = new JPanel();
        blank4 = new JPanel();
        blank5 = new JPanel();
        blank6 = new JPanel();
        buttonPanel = new JPanel();
        buttonPanel.setLayout(new GridLayout(1, 6));
        buttonPanel.add(blank1);
        buttonPanel.add(blank2);
        buttonPanel.add(blank3);
        buttonPanel.add(anti);
        buttonPanel.add(clock);
        buttonPanel.add(ok);
        buttonPanel2 = new JPanel();
        buttonPanel2.setLayout(new GridLayout(1, 6));
        buttonPanel2.add(blank4);
        buttonPanel2.add(blank5);
        buttonPanel2.add(blank6);
        buttonPanel2.add(disc1);
        buttonPanel2.add(disc2);
        buttonPanel2.add(disc3);
        panelForStuff.add(myPanel(), BorderLayout.CENTER);
        panelForStuff.add(buttonPanel, BorderLayout.SOUTH);
        panelForStuff.add(buttonPanel2, BorderLayout.NORTH);
        getContentPane().add(panelForStuff);
        setSize(800, 500);
        setVisible(true);
    public static void main(String args[])
        SafeCracker application = new SafeCracker();
        application.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

Answer 1

Hi,
but I just ran this with no pictures - and it drew it
properly.
So it's something to do with bringing the pictures in.
Can anybody see where my error is?I haven't looked at your code but the statement above might indicate that you need to wait till the images are loaded. Try to add them to a mediatracker, and see if that solves your problems.
http://java.sun.com/j2se/1.4.2/docs/api/java/awt/MediaTracker.html
/Kaj