Game controll problem with keyAdapter

Question

hi folks,
I have build an game in which i want to move the player sprite with the W,A,S,D keys(use them as arrows as in maby games). It works fine, but for example: when i walk up(w) en press then (a) to walk diagonal across the screen the sprite hangs for an moment. before it actualy does go diagonal across the screen. How can i get this movement without any hanging?
I got the following code in my application: (where up, down, left and right are instance variables)
private void activateGameControlsKeys(){
          addKeyListener(new KeyAdapter(){
               public void keyPressed(KeyEvent e){
                    int keyCode = e.getKeyCode();
                    if(!isPaused&&!gameOver){
                         if(keyCode == KeyEvent.VK_W){
                              up = true;
                         if(keyCode == KeyEvent.VK_S){
                              down = true;
                         if(keyCode == KeyEvent.VK_A){
                              left = true;
                         if(keyCode == KeyEvent.VK_D){
                              right = true;
                         if(up){
                              player.movePlayer("W");
                         if(down){
                              player.movePlayer("S");
                         if(left){
                              player.movePlayer("A");
                         if(right){
                              player.movePlayer("D");
               public void keyReleased(KeyEvent e){
                    if(!isPaused&&!gameOver){
                         int keyCode = e.getKeyCode();
                         if(keyCode == KeyEvent.VK_W){
                              up = false;
                         }else if(keyCode == KeyEvent.VK_S){
                              down = false;
                         }else if(keyCode == KeyEvent.VK_A){
                              left = false;
                         }else if(keyCode == KeyEvent.VK_D){
                              right = false;
          });Hope someone can help me out..
Greetz,

Answer 1

hi folks,
I have build an game in which i want to move the
player sprite with the W,A,S,D keys(use them as
arrows as in maby games). It works fine, but for
example: when i walk up(w) en press then (a) to walk
diagonal across the screen the sprite hangs for an
moment. before it actualy does go diagonal across the
screen. How can i get this movement without any
hanging?
I got the following code in my application: (where
up, down, left and right are instance variables)
private void activateGameControlsKeys(){
          addKeyListener(new KeyAdapter(){
               public void keyPressed(KeyEvent e){
                    int keyCode = e.getKeyCode();
                    if(!isPaused&&!gameOver){
                         if(keyCode == KeyEvent.VK_W){
                              up = true;
                         if(keyCode == KeyEvent.VK_S){
                              down = true;
                         if(keyCode == KeyEvent.VK_A){
                              left = true;
                         if(keyCode == KeyEvent.VK_D){
                              right = true;
                         if(up){
                              player.movePlayer("W");
                         if(down){
                              player.movePlayer("S");
                         if(left){
                              player.movePlayer("A");
                         if(right){
                              player.movePlayer("D");
               public void keyReleased(KeyEvent e){
                    if(!isPaused&&!gameOver){
                         int keyCode = e.getKeyCode();
                         if(keyCode == KeyEvent.VK_W){
                              up = false;
                         }else if(keyCode == KeyEvent.VK_S){
                              down = false;
                         }else if(keyCode == KeyEvent.VK_A){
                              left = false;
                         }else if(keyCode == KeyEvent.VK_D){
                              right = false;
          });Hope someone can help me out..
Greetz,Wait, what?
Your making it to complicated. Anyway, it would be easier if you did this:
private void activateGameControlsKeys()
{ addKeyListener(new KeyAdapter(){public void keyPressed(KeyEvent e)
{ int keyCode = e.getKeyCode();
if(!isPaused&&!gameOver)
{ if(keyCode == e.VK_UP)
{ //Execute code here }
if(keyCode == e.VK_DOWN)
{ //Execute code here }
if(keyCode == e.VK_LEFT)
{ //Execute code here }
if(keyCode == e.VK_RIGHT)
{ //Execute code here }
} } } ); }I think i got the right amount of { things...
Anyway, execute the code within the keyPressed code, it's much easier. Believe me, I know. And the code won't repeat itself if you don't have the keyRelease code. And I have the same problem with the sprite hanging, it's just the way the code executes. I tried to find a way around it, but with no luck. I hope my revision of your code helps some.
Message was edited by:
g@m3r